repair_http_framing hack for Squid v6 #248
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version contains support for repairing HTTP header fields with names containing non-token characters. Also: Allow using just-parsed HTTP responses with ACLFilledChecklist. The lack of HttpReply locking meant that we could not (safely) use the freshly created reply object for ACLs checks because ACLFilledChecklist destructor would unwittingly destroy the object (by unlocking it). There was at least one such ACL check (in handle1xx()), but we got lucky because that method also added the reply object to ALE, increasing its reference counter. TODO: That above addition to ALE should probably happen earlier and unconditionally. This change also protects from HttpReply memory leaks when an exception is thrown between HttpReply creation and a setVirginReply() call.
Also adjusted a local static according to the 'no-globals' approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repair_http_framing implementation also repairs HTTP header fields
with names containing non-token characters.
Also allow using just-parsed HTTP responses with ACLFilledChecklist, as
was done in recent master/v7 commit 80a6a08.