Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Tunnel Server RESPONSE dumps #279

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Improve Tunnel Server RESPONSE dumps #279

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f80ca75
Fix Tunnel Server RESPONSE dumps
eduard-bagdasaryan Dec 26, 2024
6f56194
Avoid printing multiple RESPONSE messages
eduard-bagdasaryan Dec 27, 2024
05e4c0f
Undone an out-of-scope change
eduard-bagdasaryan Dec 27, 2024
9664b02
Added an XXX about code dulication
eduard-bagdasaryan Dec 29, 2024
fb51e46
Bug 5093: List http_port params that https_port/ftp_port lack (#1977)
kinkie Jan 7, 2025
5fa48bb
Bug 5311: clarify configuration byte units (#1979)
kinkie Jan 9, 2025
544997c
Merge branch 'master' into SQUID-1033-fix-tunnel-server-resonse-dumps
rousskov Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/clients/HttpTunneler.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,12 @@ Http::Tunneler::handleResponse(const bool eof)
hp = new Http1::ResponseParser;

auto parsedOk = hp->parse(readBuf); // may be refined below

debugs(11, 2, "Tunnel Server " << connection);
debugs(11, 2, "Tunnel Server RESPONSE:\n---------\n" <<
Raw(nullptr, readBuf.rawContent(), readBuf.length()).minLevel(2).gap(false) <<
rousskov marked this conversation as resolved.
Show resolved Hide resolved
"----------");

readBuf = hp->remaining();
if (hp->needsMoreData()) {
if (!eof) {
Expand Down Expand Up @@ -313,11 +319,6 @@ Http::Tunneler::handleResponse(const bool eof)
futureAnswer.peerResponseStatus = rep->sline.status();
request->hier.peer_reply_status = rep->sline.status();

debugs(11, 2, "Tunnel Server " << connection);
debugs(11, 2, "Tunnel Server RESPONSE:\n---------\n" <<
Raw(nullptr, readBuf.rawContent(), rep->hdr_sz).minLevel(2).gap(false) <<
"----------");

// bail if we did not get an HTTP 200 (Connection Established) response
if (rep->sline.status() != Http::scOkay) {
// TODO: To reuse the connection, extract the whole error response.
Expand Down