feature/register #3
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #3 +/- ##
===========================================
- Coverage 56.64% 54.57% -2.08%
===========================================
Files 13 13
Lines 1061 1061
Branches 245 245
===========================================
- Hits 601 579 -22
- Misses 460 477 +17
- Partials 0 5 +5 |
web/components/bns-name-row.tsx
Outdated
| setIsLoading(false); | ||
| } | ||
|
|
||
| checkAvailability(); |
There was a problem hiding this comment.
There are a few spots where ESLint errors are shown, like here. Mostly all small things but it'd be good to get ESLint validation setup in your editor
| namespace: asciiToBytes(namespace), | ||
| amount: Number(price), | ||
| hashedFqn: hashFqn(name, namespace, '00'), | ||
| salt: hexToBytes('00'), |
There was a problem hiding this comment.
We should use random hex here, because it'll work better in edge cases where people need to re-submit a preorder. There is a helper in the core package
There was a problem hiding this comment.
was having a bit of trouble using the randomSalt() function, might have to refactor the hashFqn as I think its generating different values when registering for both the hashedFqn and salt params
also moved client tests to vitest
This is a workaround for running devnet with OrbStack
hstove
force-pushed
the
feature/register
branch
from
140b3f0
to
b9d14a4
Compare
Description
Starting point for adding the ability to register BNS names.
Changes
hashFqnfunction inside thepackages/coreto match functionality used in other areas of codebase