Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTL Support and Fix UI Issues in RTL for Admin UI V1.x #8245

Open
wants to merge 7 commits into
base: v1.x
Choose a base branch
from

Conversation

MEClouds
Copy link

Pull Request: Add RTL Support and Fix UI Issues in RTL for Medusa Admin UI v1.x

Overview

This pull request introduces RTL (Right-to-Left) support and addresses various UI issues when using RTL layout in the Medusa Admin UI v1.x. It resolves issue #8086

Changes

  1. Direction Based on Language:

    • Implemented direction changes based on the language direction (RTL/LTR) in the i18n configuration.
    • The direction of the application now dynamically adjusts based on the selected language.
  2. Tailwind Styles Adaptation:

    • Utilized Tailwind CSS classes that support both RTL and LTR directions without issues.
    • Converted the following classes:
      • pl to ps
      • pr to pe
      • ml to ms
      • mr to me
      • left to start
      • right to end
      • And other similar adjustments
    • Ensured consistent and correct styling across different directional layouts.
  3. Component-Specific Direction Properties:

    • Added dir properties to components that did not respond to the root direction setting, such as the dropdown menu.
    • Ensured these components display correctly in both RTL and LTR modes.
  4. Styling Fixes:

    • Fixed styling issues in tanstack/react-table to ensure proper display and functionality in RTL.
    • Addressed styling issues with switch and radio button components to ensure consistent behavior and appearance in RTL.

Additional Notes

  • Ensured that all changes are backward compatible and do not affect the LTR layout.
  • Tested the changes extensively to ensure there are no regressions or new issues introduced.
  • Please review the changes and provide feedback or suggestions for further improvements.

Thank you for your attention to this pull request. I look forward to your feedback and hope these changes improve the usability of Medusa Admin-UI for RTL languages.

@MEClouds MEClouds requested a review from a team as a code owner July 23, 2024 14:45
Copy link

changeset-bot bot commented Jul 23, 2024

⚠️ No Changeset found

Latest commit: 945fc5a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 23, 2024

@MEClouds is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@MEClouds
Copy link
Author

@kasperkristensen

@kasperkristensen
Copy link
Contributor

Thanks for the PR @MEClouds. We are quite busy with working on V2 at the moment, but I will give this a review in the coming weeks.

@MEClouds MEClouds requested a review from a team as a code owner August 13, 2024 15:56
@alisafavi
Copy link

How can use this customization ?
Should I publish it in to npm ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants