Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PluginDataParam type definitions to include text label and pro… #3266

Merged

Conversation

veeting
Copy link
Contributor

@veeting veeting commented Aug 28, 2023

We have identified that PluginDataParam has a few missing type definitions in janus.d.ts

  • text
  • label as optional
  • protocol as optional

NOTE:

janus.js is either using text or data which is confusing. The html demos are only referring to text.
Thus, we have decided to not add data and add text as optional to avoid breaking any other app.

@lminiero
Copy link
Member

janus.js is either using text or data which is confusing. The html demos are only referring to text.
Thus, we have decided to not add data and add text as optional to avoid breaking any other app.

I'd rather both are kept in there, with the idea only data will remain someday. text is legacy from when we only supported text data, which is not the case anymore: we support binary data too. The fact that demos only refer to that is simply a conseguence of those legacy assumptions.

@lminiero
Copy link
Member

Thanks for the fix, merging!

@lminiero lminiero merged commit ca2f170 into meetecho:master Aug 29, 2023
8 checks passed
spscream pushed a commit to spscream/janus-gateway that referenced this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants