AudioBridge stop_all_files api #3403
Conversation
| json_object_set_new(event, "room", | ||
| string_ids ? json_string(audiobridge->room_id_str) : json_integer(audiobridge->room_id)); | ||
| json_object_set_new(event, "file_id", json_string(p->annc->id)); | ||
| janus_audiobridge_notify_participants(p, event, TRUE); |
There was a problem hiding this comment.
Why are you passing TRUE here? That's notify_source_participant, which should be FALSE in this case because the janus_audiobridge_participant instance you're passing to the function is an announcement, and so not a real participant with a Janus API session we can notify about stuff.
There was a problem hiding this comment.
Hi @lminiero
-
stop_fileaudiobridge sendsannouncement-stoppedevent.
https://github.com/keremcadirci/janus-gateway/blob/65a23f56da9788bd4d2a733f5f1f613ff0ff489d/src/plugins/janus_audiobridge.c#L5668 -
play_fileresults withannouncement-started
How should we continue? Should we change stop_file and play_file to FALSE too
My own preference is to leave TRUE since in we want to notify participants about these events
meetecho#3403 stop_all_files, refactor
The continuation of the PR #3392
This is a cleaner PR with all #3392 commits are merged into a single commit.
All Conflicts are solved