Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCP tutorials #227

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

VCP tutorials #227

wants to merge 26 commits into from

Conversation

ziw-liu
Copy link
Collaborator

@ziw-liu ziw-liu commented Mar 3, 2025

Tutorial notebooks for the Virtual Cell Platform.

@ziw-liu ziw-liu added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 3, 2025
# %%
# Install VisCy with the optional dependencies for this example
# See the [repository](https://github.com/mehta-lab/VisCy) for more details
# !pip install "viscy[metrics,visual]==0.3.0rc2"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a release candidate for now. @mattersoflight I think we can aim for a 'stable' release after testing and merging these tutorials, so the version that is deployed in production can point to it.
cc @edyoshikun

@ziw-liu ziw-liu added the translation Image translation (VS) label Mar 4, 2025
@ziw-liu ziw-liu marked this pull request as ready for review March 5, 2025 18:14
@ziw-liu ziw-liu added this to the v0.3.0 milestone Mar 5, 2025
Copy link
Member

@mattersoflight mattersoflight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tutorial reads well. The huggingface demo does allow inference with VSCyto2D. So the differential value of VCP tutorial is to demonstrate all 3 key models. @ziw-liu let's add them since we also describe them in model card.

# ?FullyConvolutionalMAE

# %%
vs_cyto_2d = FcmaeUNet.load_from_checkpoint(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we illustrate inference with vs_cyto_3d and VSNeuromast?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be best if we just have and load yml config files for each case.

# Adjust based on available memory (reduce if seeing OOM errors)
batch_size=8,
# Number of workers for data loading
# Set to 0 for Windows and macOS if running in a notebook,
Copy link
Contributor

@edyoshikun edyoshikun Mar 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the past we had set the num_workers=0 given the Windows/Mac issue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google Colab always runs on Linux so I'm using MP to make it faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request translation Image translation (VS)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants