Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow retrieving vectors when fetching documents #607

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xarantolus
Copy link

Pull Request

This adds fields that are required for retrieving vectors from Meili.

Related issue

I didn't open an issue as I just fixed it - however, if you want a more proper discussion about how to add this, I can open one.

What does this PR do?

  • Adds the retrieveVectors option for document fetching endpoints to the Go client
  • This is required for end-users who work with the vectors stored in their index

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.05%. Comparing base (40ea18f) to head (d262492).

Files with missing lines Patch % Lines
index_document.go 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
- Coverage   86.23%   86.05%   -0.19%     
==========================================
  Files          14       14              
  Lines        2848     2854       +6     
==========================================
  Hits         2456     2456              
- Misses        282      287       +5     
- Partials      110      111       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ja7ad
Copy link
Collaborator

Ja7ad commented Feb 16, 2025

@xarantolus Possible write unit test for this param?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants