Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generate Cloudflare account token on deploy #141

Merged
merged 9 commits into from
Jan 20, 2025
Merged

feat: generate Cloudflare account token on deploy #141

merged 9 commits into from
Jan 20, 2025

Conversation

augustoccesar
Copy link
Collaborator

No description provided.

ostenbom
ostenbom reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@ostenbom ostenbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking gooooodd!

Can we add some kind of logging on deploy that says like "This is the only time you'll get to see this token, make sure to take a copy" or something?

linkup-cli/src/commands/deploy/resources.rs Outdated
@@ -5,6 +5,7 @@ use sha2::{Digest, Sha256};

use super::{api::CloudflareApi, cf_deploy::DeployNotifier, DeployError};

const LINKUP_ACCOUNT_TOKEN_NAME: &str = "linkup-account-token";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if a different name might clarify the way this is used better - like linkup-account-owned-cli-access-token ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed on bffa1f0

@augustoccesar
Copy link
Collaborator Author

Can we add some kind of logging on deploy that says like "This is the only time you'll get to see this token, make sure to take a copy" or something?

Something like this? edc2252

@augustoccesar augustoccesar marked this pull request as ready for review January 20, 2025 11:58
@augustoccesar augustoccesar merged commit c824f1b into main Jan 20, 2025
4 checks passed
@augustoccesar augustoccesar deleted the augustoccesar/generate-cf-token branch January 20, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ostenbom ostenbom ostenbom approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@augustoccesar @ostenbom