feat: use zones names when naming Cloudflare resources #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostenbom
reviewed
Feb 18, 2025
| @@ -58,9 +58,12 @@ pub async fn deploy(args: &DeployArgs) -> Result<(), DeployError> { | |||
| ); | |||
| let notifier = ConsoleNotifier::new(); | |||
|
|
|||
| let tunnel_zone_name = cloudflare_api.get_zone_name(&args.zone_ids[0]).await?; | |||
There was a problem hiding this comment.
Why tunnel zone name and not like zone1name-zone2name list? the script is "global" and will be associated with "all" the zones / have worker routes in several places
There was a problem hiding this comment.
No specific reason! Just thought maybe it was enough.
Is this better? e71238d
augustoccesar
changed the title
augustoccesar
deleted the
augustoccesar/use-zone-name-for-creating-resources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.