feat: add authentication to /linkup/certificate* endpoints
#168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostenbom
reviewed
Feb 20, 2025
augustoccesar
commented
Feb 20, 2025
Comment on lines
+91
to
+101
| // Namespace is not guarantee to exist on all bindings. It exists for type `kv_namespace`, but not for `plain_text`, for example. | ||
| // This should probably be an enum over the possible types of bindings. Something like what we did on deploy/api.rs: | ||
| // | ||
| // #[derive(Debug, Clone)] | ||
| // pub enum WorkerBinding { | ||
| // KvNamespace { name: String, namespace_id: String }, | ||
| // PlainText { name: String, text: String }, | ||
| // SecretText { name: String, text: String }, | ||
| // } | ||
| // | ||
| // pub namespace_id: String, |
There was a problem hiding this comment.
ostenbom
approved these changes
Feb 20, 2025
augustoccesar
deleted the
augustoccesar/authenticate-linkup-endpoints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related changes:
Closes DO-1928