feat: scheduled clean up of unused tunnels #172
Merged
+411
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostenbom
reviewed
Feb 20, 2025
worker/src/lib.rs
Outdated
| #[event(scheduled)] | ||
| async fn scheduled(event: worker::ScheduledEvent, env: Env, _ctx: worker::ScheduleContext) { | ||
| // Is the every weekday at midday schedule | ||
| if event.cron() == "0 12 * * 2-6" { |
There was a problem hiding this comment.
Why is this check needed? Just run whenever scheduled?
There was a problem hiding this comment.
We don't really need it hahah since we just have one schedule, is fine to just do it.
Changed on 3554a1f
|
|
||
| let now = worker::Date::now(); | ||
|
|
||
| for key in tunnels_keys { |
There was a problem hiding this comment.
Did you need to add to remove the key in here after delete too?
There was a problem hiding this comment.
Not sure if I get what you mean 🤔
There was a problem hiding this comment.
As in remove the key/value tunnel pair from the kv store after deleting the dns record and tunnel?
There was a problem hiding this comment.
Aha! Yes! Added on bbfb665
ostenbom
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes DO-1929