Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only route local dns to active sessions #60

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Only route local dns to active sessions #60

merged 3 commits into from
Feb 21, 2024

Conversation

ostenbom
Copy link
Contributor

@ostenbom ostenbom commented Feb 21, 2024 •
edited
Loading

  • Users may want to view other linkup sessions, or preview environments.
  • With local-dns enabled, all these are routed to the local server where the session does not exist
  • Default dnsmasq to route to the public internet, but add special rules for the active local session instead
  • An annoying side-effect of this is still that linkup needs to be started (for dnsmasq to be started) to view sessions, but 🤷

@ostenbom
Only route local dns to active sessions
e1e4d66 
- Users may want to view other linkup sessions, or preview environments.
- With local-dns enabled, all these are routed to the local server where
  the session does not exist
- Default dnsmasq to route to the public internet, but add special rules
  for the active local session instead
@ostenbom ostenbom merged commit 6d89ac2 into main Feb 21, 2024
4 checks passed
@ostenbom ostenbom deleted the oliver/dnsmasq-only-active-session branch February 21, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augustoccesar augustoccesar augustoccesar approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ostenbom @augustoccesar