fix: off by one error env file without new line #62
Conversation
### Description When looking into the start index of the matching, it gets the index of the initial matching char. Which means that to get the last char, we should add the size of the separator - 1 to take into consideration that the index start on the first char.
linkup-cli/src/env_files.rs
Outdated
| let expected_content = format!("{}\n{}", "EXISTING_1=VALUE_1", "EXISTING_2=VALUE_2",); | ||
| assert_eq!(expected_content, file_content); |
There was a problem hiding this comment.
I wonder if linkup should always add a newline at the end of the file if there isn't one?
There was a problem hiding this comment.
We can do that as well! Right now we are explicitly removing a last new line if there is one 🤔
There was a problem hiding this comment.
linkup/linkup-cli/src/env_files.rs
Lines 84 to 86 in e60a633
There was a problem hiding this comment.
I think this was to fix the case where this happened:
\n
\n
\n
and the file kept growing
There was a problem hiding this comment.
Maybe we can remove any repeating trailing \n to ensure there is only one left by the end of it? 🤔
There was a problem hiding this comment.
Yeah that sounds like a solid solution
There was a problem hiding this comment.
What do you think of 34ebcfb?
Description
When looking into the start index of the matching, it gets the index of the initial matching char. Which means that to get the last char, we should add the size of the separator - 1 to take into consideration that the index start on the first char.