Fix localdns, add --no-tunnel #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostenbom
force-pushed
the
oliver/no-tunnel-local-dns
branch
from
3c45999
to
224c8e7
Compare
ostenbom
force-pushed
the
oliver/no-tunnel-local-dns
branch
from
224c8e7
to
90fbe61
Compare
ostenbom
force-pushed
the
oliver/no-tunnel-local-dns
branch
from
90fbe61
to
d58b434
Compare
linkup-cli/src/background_booting.rs
Outdated
| state.linkup.tunnel = tunnel; | ||
| } else { | ||
| state.linkup.tunnel = Some(tunnel); | ||
| } else if state.should_use_tunnel() { |
There was a problem hiding this comment.
This condition is repeated twice; I think you could check for it once and move the other condition inside that If-statement as it's a little hard to follow the logic.
linkup-cli/src/main.rs
Outdated
| Start, | ||
| Start { | ||
| #[clap( | ||
| long = "no-tunnel", |
There was a problem hiding this comment.
How about a short option alias?
There was a problem hiding this comment.
Any suggestions for what it would be? I didn't have a spontaneous idea.
There was a problem hiding this comment.
Almost all options are free, so -n would do the job.
linkup-cli/src/services/dnsmasq.rs
Outdated
| .stdout(Stdio::null()) | ||
| .stderr(Stdio::null()) | ||
| // .stdout(Stdio::null()) | ||
| // .stderr(Stdio::null()) |
There was a problem hiding this comment.
Ah thanks missed that 😅
jonaslindstr
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local-dns was broke because asking dnsmasq to reload did not get it to reload the config file from start.
Here, we create the config file correctly from the beginning instead. Much nicer.
I have also added a
--no-tunnelargument, this both helps when cloudflare is down, but also to check if local-dns works 😅