Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to discover new custom resources. #279

Merged
merged 10 commits into from
Dec 25, 2023
Merged

Add ability to discover new custom resources. #279

merged 10 commits into from
Dec 25, 2023

Conversation

MUzairS15
Copy link

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@MUzairS15 MUzairS15 added the pr/draft WIP/Draft pull request label Dec 1, 2023
@leecalcote
Copy link
Member

@MUzairS15 merge conflict...

@KiptoonKipkurui
Copy link
Member

@MUzairS15 Looks good generally only the minor pointers above, great work!!

@leecalcote
Copy link
Member

@MUzairS15 is this still in draft?

MUzairS15 added 8 commits December 25, 2023 01:02
@MUzairS15 MUzairS15 removed the pr/draft WIP/Draft pull request label Dec 24, 2023
@MUzairS15
Copy link
Author

@MUzairS15 Looks good generally only the minor pointers above, great work!!

@KiptoonKipkurui I don't see any pointers.

Also will you re-review?

@MUzairS15
Copy link
Author

The failures are due to dependency on Meshkit.

organize code
4f94c69 
Signed-off-by: MUzairS15 <[email protected]>
@MUzairS15
Copy link
Author

Initially, I also resought to using Discovery API to remove hardcoding for pods, services,... as well, but since @KiptoonKipkurui has a PR in progress I am not adding that in this PR.

update meshkit package
dfd12f3 
Signed-off-by: MUzairS15 <[email protected]>
@MUzairS15
Copy link
Author

Merging by EOD

@KiptoonKipkurui
Copy link
Member

@MUzairS15 Looks good generally only the minor pointers above, great work!!

@KiptoonKipkurui I don't see any pointers.

Also will you re-review?

The pointers are as above, but they are deemed outdated by the changes you did so no pressure. Also it Looks Good to Me

@MUzairS15 MUzairS15 merged commit 7c0a7f1 into master Dec 25, 2023
1 check passed
@MUzairS15 MUzairS15 deleted the feat/discovery/cr branch December 25, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KiptoonKipkurui KiptoonKipkurui Awaiting requested review from KiptoonKipkurui

@Aisuko Aisuko Awaiting requested review from Aisuko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MUzairS15 @leecalcote @KiptoonKipkurui