Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Packet Counter #1200

Closed
wants to merge 4 commits into from
Closed

Conversation

musznik
Copy link
Contributor

@musznik musznik commented Aug 18, 2024

I’ve implemented a packet counter column. This feature, while targeted towards advanced users, provides valuable statistical insights that can greatly enhance network analysis and optimization.

packet_counter_v2

Benefits:

  • Network Load Analysis: The packet counter helps identify nodes that heavily load the network, enabling users to diagnose and mitigate potential bottlenecks, trolls or badly configured nodes.
  • Antenna Tuning: Users can evaluate the effectiveness of different antennas by analyzing packet counts, aiding in fine-tuning for optimal performance.
  • Node Discovery: This feature is useful for locating distant nodes, which is critical in scenarios like search and rescue or in remote areas.
  • Enhanced Functionality: Currently, users mainly rely on node observations, last activity times, or sending Traceroute pings. The packet counter adds another layer of functionality, enriching the experience for advanced users and providing them with more tools for network analysis.

Potential Drawbacks:

  • Interface Complexity: Adding another column may add complexity to the UI, which could be overwhelming for less experienced users.

Overall, this enhancement offers significant benefits for users needing deeper network insights, and I believe it will be a valuable addition to the project. This is just a suggestion based on needs of my community.

@b8b8
Copy link

b8b8 commented Aug 18, 2024

cool. when does it reset? every 24 hours or user configurable? This will be helpful to see which people are blasting away telemetry every 5min. This could also be put in or in addition to the upcoming data graphs and separated by data type.

@b8b8
Copy link

b8b8 commented Aug 18, 2024

my only suggestion is to move it down to the "expanded" card area that was recently added.

@musznik
Copy link
Contributor Author

musznik commented Aug 18, 2024

Good points. Currently, the counter doesn’t reset automatically, but adding a reset feature makes sense. I’ll definitely consider implementing it, along with breaking down the statistics by data type.

@b8b8
Copy link

b8b8 commented Aug 18, 2024

A rolling 1 hour may be a good start actually, not 24 hours. Its nice to see some of the mesh data being more accessible than just in the background and will really help with debugging and testing.

@garthvh
Copy link
Member

garthvh commented Aug 24, 2024

@thebentern
Copy link
Contributor

Take a look at the local stats telemetry https://github.com/meshtastic/protobufs/blob/52cfa2c1c2cd5a1a714e1338d551d967f674fca8/meshtastic/telemetry.proto#L236

Yeah, please use this API because we have precedence here on the Apple apps. It has more raw data available from the device as well

Copy link
Member

@andrekir andrekir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add that the node list really isn't the right place for a packet count. our NodeInfo data class simply mirrors the NodeInfo protobuf.

also avoid JSON in SharedPreference for persistence. and no need to add serialization-json lib as it's already being used (but hopefully removed soon).

implementation "org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.1"

@andrekir andrekir closed this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants