-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node Packet Counter #1200
Node Packet Counter #1200
Conversation
cool. when does it reset? every 24 hours or user configurable? This will be helpful to see which people are blasting away telemetry every 5min. This could also be put in or in addition to the upcoming data graphs and separated by data type. |
my only suggestion is to move it down to the "expanded" card area that was recently added. |
Good points. Currently, the counter doesn’t reset automatically, but adding a reset feature makes sense. I’ll definitely consider implementing it, along with breaking down the statistics by data type. |
A rolling 1 hour may be a good start actually, not 24 hours. Its nice to see some of the mesh data being more accessible than just in the background and will really help with debugging and testing. |
Take a look at the local stats telemetry https://github.com/meshtastic/protobufs/blob/52cfa2c1c2cd5a1a714e1338d551d967f674fca8/meshtastic/telemetry.proto#L236 |
Yeah, please use this API because we have precedence here on the Apple apps. It has more raw data available from the device as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add that the node list really isn't the right place for a packet count. our NodeInfo data class simply mirrors the NodeInfo protobuf.
also avoid JSON in SharedPreference for persistence. and no need to add serialization-json
lib as it's already being used (but hopefully removed soon).
Meshtastic-Android/app/build.gradle
Line 225 in 7b44fea
implementation "org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.1" |
I’ve implemented a packet counter column. This feature, while targeted towards advanced users, provides valuable statistical insights that can greatly enhance network analysis and optimization.
Benefits:
Potential Drawbacks:
Overall, this enhancement offers significant benefits for users needing deeper network insights, and I believe it will be a valuable addition to the project. This is just a suggestion based on needs of my community.