Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix signal quality display when rssi missing #933

Conversation

powersjcb
Copy link
Contributor

@powersjcb powersjcb commented Sep 14, 2024

What changed?

Fixed incorrect signal quality caculations when RSSI was not present. (this is common because NodeInfo does not store RSSI)

Hide RSSI when value is 0 (unknown).

#930

Why did it change?

UI was showing misleading signal quality metrics.

How is this tested?

Screenshots/Videos (when applicable)

image

Checklist

  • My code adheres to the project's coding and style guidelines.
  • I have conducted a self-review of my code.
  • I have commented my code, particularly in complex areas.
  • I have made corresponding changes to the documentation.
  • I have tested the change to ensure that it works as intended.

@garthvh garthvh merged commit c92394e into meshtastic:main Sep 15, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants