quickjs-ng: new wrap #1865
quickjs-ng: new wrap #1865
Conversation
trim21
force-pushed
the
quick-ng
branch
5 times, most recently
from
5792666 to
01fcdf5
Compare
trim21
force-pushed
the
quick-ng
branch
6 times, most recently
from
87514cf to
e44653c
Compare
| quickjs_lib = static_library('quickjs', lib_src, dependencies: deps) | ||
|
|
||
| quickjs_ng_dep = declare_dependency( | ||
| include_directories: include_directories('.'), |
There was a problem hiding this comment.
I don't think this is a good idea.
It exposes all headers, creating name collisions downstream.
I encountered the same problem when adapting other projects like tcc or mongoose.
The trick I used to avoid this, is like what I have done in here: https://github.com/lazy-eggplant/vs.http/tree/master/subprojects/packagefiles/mongoose
Basically I create a meson-include folder, and add symbolic links to the required headers in there.
However, this had a bug up until recently mesonbuild/meson#14073 so it would not work with older versions :(.
There was a problem hiding this comment.
which means there is no available meson release support this?
In this case looks like I should not do this, or I need set meson version limit to >1.6.1 ....
There was a problem hiding this comment.
The only other alternatives I can see are
- to fork the project & better organize files so that we can have sane search paths
- Add some intermediate target which makes those symlinks, and define it as dep for the actual targets. Basically the folder gets patched while building and not by wrap applying the patch. It is not a sane approach, but it would support older versions of meson.
- keep the
.and accepting things will break downstream when building, in scenarios which are quite obscure and hard to predict.
For context, a file config.h in tinycc was creating problems in one of my projects, but only on macos-14 with clang-19. I wasted way to many hours to figure that out. Basically you would encounter this sorts of issues :(
There was a problem hiding this comment.
This is the only public header of quichjs-ng, I think we should be able to just copy this file to subprojects/packagefiles/quickjs-ng/include/ to avoid this?
There was a problem hiding this comment.
Yes, it is possible I guess. It makes the process of maintaining the patch more annoying than what it should be. But it would work.
There was a problem hiding this comment.
I'm trying option 2 and try to make it copy/symlink header file to include/ but looks like it's not possible at generate time and it will require downstream users to try to build project once to make these intermediate target to be executed.
If someone just run meson setup there is no target will be executed.
There was a problem hiding this comment.
this should work? I add a file to redirect the include https://github.com/mesonbuild/wrapdb/pull/1865/files#diff-4249ae485f283cd937be82c135e3137bf864fe201cb7e312d14debcd93f8f13f
using a symlink doesn't look very portable
|
We might also generate the pkg for the library. Many which are distributed in wrapdb do. |
I add pkg-config support, but I'm not sure if it will work with current dummy include? I hardly know pkg-config |
|
is it possible to decompress tar as quickjs-ng instead of default quickjs？ In case someone has both wrap for quickjs and quickjs-ng |
Not ready for merge.
Add new wrap for quickjs-ng
cc @KaruroChori for some help and review