Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fading problem when only two slides #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

naokazuterada
Copy link

@naokazuterada naokazuterada commented Oct 21, 2021

Thanks for the great plugin.

I found a small problem and will send you a report and suggested fix.

Reproduction

When there are two slides, when returning from the second slide to the first, the first slide is displayed instantly instead of fading (this problem did not seem to be reproduced when there were three or more slides).

Solution

I haven't investigated it too closely, but I think it is caused by the negative value of "progress".

If there is a better fix, it's OK not to merge.

@gavin310
Copy link

@desandro This fix works great. Why not merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants