Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set flickity as peerDependecy #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emateu
Copy link

@emateu emateu commented Jul 11, 2019

Scenario

Combining flickity with multiples plugins, like flickity-fullscreen and flickity-as-nav-for.

Issue

Since we have flickity as a dependency, will extend flickity from it's own node_modules instead of extending the one of the project's node_modules.

This makes impossible to combine two plugins.

Solution

Define on the plugin, flickity as a peerDependency.

--

If you merge this, we should do the same on https://github.com/metafizzy/flickity-as-nav-for

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant