Skip to content

Commit

Permalink
πŸ“ v4 CodePen links; revise tasks in PR notes
Browse files Browse the repository at this point in the history
  • Loading branch information
desandro committed Jan 3, 2021
1 parent 40834c7 commit 5cfdedf
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions .github/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ All bug reports and problem issues require a [**reduced test case**](https://css
+ It contains the bare minimum HTML, CSS, and JavaScript required to demonstrate the bug.
+ A link to your production site is **not** a reduced test case.

Create one by forking any one of the [CodePen demos](https://codepen.io/desandro/tag/infinite-scroll-v3-docs) from [the docs](https://infinite-scroll.com).
Create one by forking any one of the [CodePen demos](https://codepen.io/collection/DZejqa?grid_type=list&sort_by=item_created_at) from [the docs](https://infinite-scroll.com).

+ [Scroll & append](https://codepen.io/desandro/pen/WOjqNM)
+ [Scroll & append, vanilla JS](https://codepen.io/desandro/pen/WOpjMM)
+ [Scroll & append](https://codepen.io/desandro/pen/yLaKLop)
+ [Scroll & append, vanilla JS](https://codepen.io/desandro/pen/vYXRYeY)

Providing a reduced test case is the best way to get your issue addressed. They help you point out the problem. They help me verify and debug the problem. They help others understand the problem. Without a reduced test case or live URL, your issue may be closed.

Expand All @@ -21,8 +21,8 @@ Contributions are welcome!

+ **For typos and one-line fixes,** send those right in.
+ **For larger features,** open an issue before starting any significant work. Let's discuss to see how your feature fits within Infinite Scroll's vision.
+ **Follow the code style.** Spaces in brackets, semicolons, trailing commas.
+ **Check code style.** Run `npm run lint`. Spaces in brackets, semicolons, trailing commas.
+ **Do not edit `infinite-scroll.pkgd.js`.** Make your edits to source files in `js/`.
+ **Do not run `gulp` to update `dist/` files.** I'll take care of this when I create a new release.
+ **Do not run the `dist` task to update `dist/` files.** I'll take care of this when I create a new release.

Your code will be used as part of a commercial product if merged. By submitting a Pull Request, you are giving your consent for your code to be integrated into Flickity as part of a commercial product.
Your code will be used as part of a commercial product if merged. By submitting a Pull Request, you are giving your consent for your code to be integrated into Infinite Scroll as part of a commercial product.
2 changes: 1 addition & 1 deletion .github/issue_template.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<!-- Thanks for submitting an issue! All bug reports and problem issues require a **reduced test case** or **live URL**. Create one by forking any one of the CodePen examples from the docs. See guidelines link above. -->

**Test case:** http://codepen.io/desandro/pen/WOjqNM
**Test case:** https://codepen.io/desandro/pen/yLaKLop

0 comments on commit 5cfdedf

Please sign in to comment.