'fitrows': Last row item should always fit #1565
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last item in a row sometimes does not fit due to floating point inaccuracies. Related issue: metafizzy#1563
marcigo36
commented
Oct 19, 2020
| @@ -42,7 +42,7 @@ proto._getItemLayoutPosition = function( item ) { | |||
| var itemWidth = item.size.outerWidth + this.gutter; | |||
| // if this element cannot fit in the current row | |||
| var containerWidth = this.isotope.size.innerWidth + this.gutter; | |||
| if ( this.x !== 0 && itemWidth + this.x > containerWidth ) { | |||
| if ( this.x !== 0 && itemWidth + this.x > containerWidth + 0.001 /*to prevent last item not fitting in some cases*/ ) { | |||
There was a problem hiding this comment.
I am not sure what is a safe value for this across all browsers.
Number.EPSILON definitely does not work.
Using something like 0.000001 has proven to be too small as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last item in a row sometimes does not fit due to floating point inaccuracies.
Related issue: #1563