GutterWidth and GutterHeight options #384
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated and is set to both gutterWidth and gutterHeight is present in options. Add a sandbox file.
|
Thanks so much for this contribution! This is tremendous work. But I'm a bit particular about the implementation. Having // single value for both gutterWidth and gutterHeight
gutter: 20
// use width of element for width and height (to maintain backwards compatibility)
gutter: '.gutter-sizer'
// separate values for width and height, set as array
gutter: [ 20, 10 ]
// element width for width, element height for height
gutter: [ '.gutter-sizer', '.gutter-sizer' ]I appreciate all the word you did here. This issue has gained enough interest that this PR would make a great addition. |
|
Yeah an array is a better idea :) and more flexible indeed ! |
| @@ -63,7 +63,11 @@ var proto = Packery.prototype; | |||
| proto._create = function() { | |||
| // call super | |||
| Outlayer.prototype._create.call( this ); | |||
|
|
|||
| //handle gutter | |||
| if(this.gutter) { | |||
There was a problem hiding this comment.
it's not available here, need to use this.options.gutter
|
@MrGrabazu thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add the support of
gutterWidthandgutterHeightoptions.If
gutteroption is provided so it will be dispatched togutterWidthandgutterHeight.If a class name is provided, I set the
widthcss property value togutterWidthoption andheightcss property value togutterHeightoption.Tell me what do you think about it.