Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the ability to configure event listener options, restoring ability to prevent preventDefault() in pointerDown #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tylernotfound
Copy link

Follow-up from PR to Unipointer: metafizzy/unipointer#8

Same reasoning around the need for adding listenerOpts applies.

I'm also hoping you reconsider leaving the ability to prevent event.preventDefault() in pointerDown, without actually quitting the event chain via this.okayPointerDown(). The main reason for allowing the event chain to continue without event.preventDefault() is to allow inner elements with 'click' handlers a chance to fire. Prevent default in touchstart stops the chain and prevents these events from firing. The structure I've outlined would make this behavior opt-in, leaving the always preventing behavior the default.

Also included a minor fix in the README, which was referencing an internal property that was removed.

Tyler Smith added 2 commits June 23, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant