Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix window variable in dragger #85

Closed
wants to merge 1 commit into from
Closed

fix window variable in dragger #85

wants to merge 1 commit into from

Conversation

h2jorm
Copy link

@h2jorm h2jorm commented Sep 21, 2019

When using zdog in webpack or parcel, this is not assigned to window. Use global window instead of this. Also mentioned in #49

@howardcvalve
Copy link

howardcvalve commented Oct 7, 2019 •
edited
Loading

Hi @desandro, would you consider accepting this PR to fix issues for webpack/parcel users? This relies on the window global existing, which should be fine on the client. It doesn't solve the original issue mentioned in #49, but should fix the more common use case.

desandro added a commit that referenced this pull request Oct 23, 2019
@desandro
🐞 check for browser window #49 #85 #86
3566dcb 
Addresses `this = window` mismatch with Webpack, Parcel, Gatsby.
@desandro
Copy link
Member

Thank you for this contribution! I have added this code and some more in SHA: 3566dcb. This fix has been released in v1.1.1. Email me [email protected] if you like stickers

@desandro desandro closed this Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h2jorm @howardcvalve @desandro