-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sassc dependency to Gemfile #147
Conversation
There are two errors. We need to investigate -- I suspect both of them are related to sassc. Failure at sassc path locationSo the compilation actually fails but job is marked complete for metanorma-iso The problem
Segfault in ubuntu-20.04 and metanorma-isohttps://github.com/metanorma/packed-mn/runs/4770290341?check_suite_focus=true
|
There are discussions regarding this or similar crashes that last for years Basically it is about multithreaded processing of not thread-safe array. |
(@opoudjis another reason why we shouldn't use SASS during document compilation) |
Thanks @maxirmx -- now the question is -- why is the sassc gem used in parallel? |
I can probably make it work. Just a metter of time |
Thanks @maxirmx , yes please help try make it work. It’s strange that there are parallel accesses happening there. |
Regarding the first issue:
The file is packaged into memfs as follows
but ruby does not attempt to open this file from memfs.
|
Looks like Gem.loaded_specs is loaded with incorrect (non-memfs) paths. Maybe when we override ruby’s file loading mechanisms we also need to update the file paths used in ruby (for every gem loaded, Ruby keeps the location of that gem path, as technically ruby can load from multiple gem paths). |
We do update file paths used in Ruby and all simple tests show that Gem loaded_spec points to correct location in memfs |
load_paths is handled correctly
The issue is that this gem opens files from native extension that does not know anything about memfs.
|
Hi, @ronaldtse |
@maxirmx the builds seem to be failing right now. Can we fix this and merge? Thanks. |
Can you at least point me to the repo for this gem:
|
Yes it is relaton/relaton. @andrew2net is the lead developer of Relaton. @andrew2net can you help @maxirmx with this? Thanks! |
@maxirmx the repo is "relaton/relaton-iso". |
I am now getting another error when TEST_FLAVOR is set to ogc. All platforms, including Windows so it does not seem to be related to packaging
|
@andrew2net any idea on the failure with OGC? Thanks. |
There is some floating issue with file system that I am working on |
@ronaldtse I fixed some minor issues with tebako |
@maxirmx I think this is good to go. Let’s also move the gem hacks into Tebako so other ruby projects that use these gems can also work. Let’s temporarily ignore errors for OGC, then start a separate ticket to fix OGC and assign to @andrew2net. Thanks! |
The log shows the failure is with IEEE. The IEEE has changed its site template and API. I'll update relaton-ieee parser in the next relaton release 1.10 |
Thanks @andrew2net for the clarification, I've now linked the issue relaton/relaton-ieee#13 . Let's always track with issues so we all know what's going on. Keeping mentions in particular comments outside the repository won't work. |
Metanorma PR checklist
Fixes #146