Update configuration.py #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid crash in case non-integer TRUNC values are used, e.g. when trunc is set to custom. TRUNC will still be handled as an integer in pysurfex.
trygveasp
reviewed
Oct 3, 2024
pysurfex/configuration.py
Outdated
| @@ -550,7 +550,7 @@ def __init__(self, env, conf): | |||
| gsize = float(env["LGSIZE"]) | |||
| trunc = 2 # linear | |||
| if "TRUNC" in env: | |||
| trunc = int(env["TRUNC"]) | |||
| trunc = int(float(env["TRUNC"])) | |||
There was a problem hiding this comment.
Can you remove the int? It should be treated as a float if it's a float. If you convert it to an int the 2.4 value will be truncated to 2. Otherwise I support the change as I have had to do it also myself sometimes recently:-)
There was a problem hiding this comment.
Of course. I was not sure whether TRUNC should be "allowed" to actually be 2.4 due to the initial int constrain in pysurfex.
TRUNC can now be a float.
|
Thanks. I'll merge when the checks pass. Remind me if I forget it:-) |
trygveasp
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid crash in case non-integer TRUNC values are used, e.g. when trunc is set to custom. TRUNC will still be handled as an integer in pysurfex.