Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics-util: Derive Clone for Snapshotter #472

Merged
merged 1 commit into from
Apr 17, 2024
Merged

metrics-util: Derive Clone for Snapshotter #472

merged 1 commit into from
Apr 17, 2024

Conversation

vojtechkral
Copy link
Contributor

No description provided.

@vojtechkral
Copy link
Contributor Author

CI failed due to unrelated MSRV woes.

tobz
tobz approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@tobz tobz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, yeah, I need to fix that.

Anyways, this is simple enough and looks good to me.

@tobz tobz merged commit 65f6e65 into metrics-rs:main Apr 17, 2024
8 of 12 checks passed
@tobz tobz added C-util Component: utility classes and helpers. E-simple Effort: simple. S-awaiting-release Status: awaiting a release to be considered fixed/implemented. T-ergonomics Type: ergonomics. labels Apr 17, 2024
@vojtechkral
Copy link
Contributor Author

Thanks!

@tobz tobz mentioned this pull request May 27, 2024
Closed
@tobz
Copy link
Member

tobz commented May 27, 2024

Released in [email protected].

Thanks again for your contribution. 🙏🏻

@tobz tobz removed the S-awaiting-release Status: awaiting a release to be considered fixed/implemented. label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobz tobz tobz approved these changes

Assignees
No one assigned
Labels
C-util Component: utility classes and helpers. E-simple Effort: simple. T-ergonomics Type: ergonomics.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vojtechkral @tobz