rm critical rule, add logging to remaining fw-rules #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DSDE-347: add fw rule logging / rm critical fw rule
Goal
From the JIRA-Ticket:
I want to
a) add default firewall rule logging to a terraform template of cloud foundation
b) remove fw-allow-all-iap rule as it opens up all ports and is flagged by GCP projects in general
In order to:
for a) do not need to care for our own vpc Infrastructure but do not suffer from “Medium”GCP vulnerabilities due to missing logging in several projects
for b) do not suffer from “High” GCP vulnerabilities due to open ports
Since the fw rules will always be updated, when we update our tf template, and we do that quite often recently, we want to have a universal solution, so that we do not need to turn on logging manually for fw rules every time we push a new template
Key takeaways (max 3):