Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navier miniapp #214

Merged
merged 23 commits into from
Mar 25, 2024
Merged

Navier miniapp #214

merged 23 commits into from
Mar 25, 2024

Conversation

andersonw1
Copy link
Contributor

This PR compiles PyMFEM with the navier miniapp by including the interface file navier_solver.i. The input file navier_mms.cpp is also converted to python as an example.

@chldkdtn chldkdtn requested a review from sshiraiwa March 14, 2024 01:34
@chldkdtn
Copy link

@sshiraiwa if you can review and merge this to master branch, that would be wonderful.

@sshiraiwa sshiraiwa added the in-test-with-mfem-master trigger a workflow to test using MFEM master label Mar 22, 2024
@sshiraiwa
Copy link
Member

@chldkdtn , @andersonw1, Thank you for contribution. The CI error doesn't seems caused by this PR itself. I am looking into it.

@sshiraiwa sshiraiwa added in-test-with-mfem-release trigger a workflow to test using MFEM release and removed in-test-with-mfem-master trigger a workflow to test using MFEM master labels Mar 22, 2024
Copy link
Member

@sshiraiwa sshiraiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

navier_solver.hpp contains the following methods, which takes C function pointer.
'''
void AddVelDirichletBC(VecFuncT *f, Array &attr);
void AddPresDirichletBC(ScalarFuncT *f, Array &attr);
void AddAccelTerm(VecFuncT *f, Array &attr);
'''
For Python, these methods do not make much sense, and in fact, causes build error.
I proposed that we ignore these methods using %ignore, since Python user can use Numba compiled coefficient to call these methods, as you are doing in navier_mms.py

mfem/_par/navier_solver.i Show resolved Hide resolved
@sshiraiwa
Copy link
Member

Please let us know if the suggested change is okay for you. If it is okay, we will merge it. Thank you for fantastic contribution!

@sshiraiwa sshiraiwa merged commit 324cd66 into mfem:master Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-test-with-mfem-release trigger a workflow to test using MFEM release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants