-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navier miniapp #214
Navier miniapp #214
Conversation
@sshiraiwa if you can review and merge this to master branch, that would be wonderful. |
@chldkdtn , @andersonw1, Thank you for contribution. The CI error doesn't seems caused by this PR itself. I am looking into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
navier_solver.hpp contains the following methods, which takes C function pointer.
'''
void AddVelDirichletBC(VecFuncT *f, Array &attr);
void AddPresDirichletBC(ScalarFuncT *f, Array &attr);
void AddAccelTerm(VecFuncT *f, Array &attr);
'''
For Python, these methods do not make much sense, and in fact, causes build error.
I proposed that we ignore these methods using %ignore, since Python user can use Numba compiled coefficient to call these methods, as you are doing in navier_mms.py
Please let us know if the suggested change is okay for you. If it is okay, we will merge it. Thank you for fantastic contribution! |
This PR compiles PyMFEM with the navier miniapp by including the interface file
navier_solver.i
. The input filenavier_mms.cpp
is also converted to python as an example.