Minor improvements to Bilinear Form Integrators page #310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tzanio,
The initial motivation for this PR was clarifying the requirement for H1 (vs L2) when the gradient operator is required by the bilinear integrator. We say L2 spaces have no derivative operator, but (please do correct me if I'm wrong) if mapping by value (but not by integral - why?), we do define a gradient operator. Now, I understand this gradient is local only (i.e. within an element), i.e. it's not defined in the weak sense (i.e. across elements) like in H1, and I expect this is the reason for the H1 requirement. So then I thought that maybe we should add a note explaining this, but it looks like we already say something to this effect: "Many of these operators will work with either H1 or L2 basis functions but some that require a gradient operator should be used with H1.". Is the "should" in this sentence trying to capture what I just tried to explain?
So, at the moment, the contents of this PR are fairly trivial, but we could expand a bit more on the usage of these integrators in L2 if you think that'd be appropriate.
In addition, while going down the rabbit hole of why we define a gradient when the elements are value- but not integral-mapped, I also came across this table. Some collections for which the basis type is an option are hard-coded to a specific type, e.g. compare
L2_[DIM]_[ORDER]
andL2_T[BTYPE]_[DIM]_[ORDER]
: they're both down as (open) Gauss-Legendre. Is this on purpose - if so, why?Cheers,
-Nuno