Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Loading Indicator in Folder Creation and Restrict Empty Folder Names #1318

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JeevaRamanathan
Copy link
Contributor

Addressing #1317

  1. A loading indicator has been added during the folder creation process
  2. Restricts the creation or updating of folders with empty names

@JeevaRamanathan JeevaRamanathan requested a review from mfts as a code owner October 27, 2024 23:19
Copy link

vercel bot commented Oct 27, 2024

@JeevaRamanathan is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

@JeevaRamanathan
Copy link
Contributor Author

JeevaRamanathan commented Oct 27, 2024

@mfts I noticed one additional issue: it allows the creation of a folder with single special characters like ,, -, etc. However, from the documents page, the folder is not reachable since these characters are ignored in the URL due to slugify, leading to a 404 page. Should we restrict such names during folder creation, for example, starting with only number/alphabets, or allow them in the path?

image

@mfts
Copy link
Owner

mfts commented Oct 31, 2024

/award 150

Copy link

oss-gg bot commented Oct 31, 2024

Awarding JeevaRamanathan: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/JeevaRamanathan

@mfts mfts added revisit Currently not required but important in the future 🕹️ oss.gg iteration-1 awarded labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awarded iteration-1 🕹️ oss.gg revisit Currently not required but important in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants