Add PKCE to Okta auth #1400
Open
Add PKCE to Okta auth #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbit-aaron
force-pushed
the
add-okta-pkce-support
branch
2 times, most recently
from
06ff984
to
cdd19bd
Compare
rabbit-aaron
force-pushed
the
add-okta-pkce-support
branch
from
cdd19bd
to
4eb8490
Compare
rabbit-aaron
commented
Oct 14, 2024
| @@ -268,19 +292,31 @@ def _OAUTH_AUTHORIZE_URL(self): | |||
| def _OAUTH_ACCESS_TOKEN_URL(self): | |||
| return f"{self.base_url}/v1/token" | |||
|
|
|||
| @property | |||
| def _oauth_okta_scope(self): | |||
| return self.application.options.oauth2_okta_scope.split() | |||
There was a problem hiding this comment.
OKTA supports adding different claims to the ID token based on the scopes set.
In our case we needed the "groups" claim and that is configured to require a "groups" scope in the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okta supports PKCE with Client ID / Client Secret authentication.
In OAuth 2.1 (currently draft), auth code flow is recommended to use PKCE.
https://datatracker.ietf.org/doc/draft-ietf-oauth-v2-1/