Fix some warnings

mhutch · May 17, 2024 · 4550d9e · 4550d9e
1 parent 8673379
commit 4550d9e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/MSBuildLanguageServer/MSBuildLanguageServer.csproj b/MSBuildLanguageServer/MSBuildLanguageServer.csproj
@@ -7,6 +7,11 @@
     <RootNamespace>MonoDevelop.MSBuild.Editor.LanguageServer</RootNamespace>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <OutputType>Exe</OutputType>
+    <NoWarn>
+      $(NoWarn);
+      <!-- imported roslyn code triggers VS threading analyzer warnings -->
+      VSTHRD003;VSTHRD103;VSTHRD110;VSTHRD002
+    </NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/MSBuildLanguageServer/RequestContext.cs b/MSBuildLanguageServer/RequestContext.cs
@@ -12,7 +12,7 @@ readonly struct RequestContext (ILspServices services, ILspLogger logger)
 	public ILspLogger Logger { get; } = logger;
 	public WellKnownLspServerKinds ServerKind => WellKnownLspServerKinds.MSBuild;
 
-	public static async Task<RequestContext> CreateAsync(
+	public static Task<RequestContext> CreateAsync(
 		bool mutatesSolutionState,
 		bool requiresLSPSolution,
 		TextDocumentIdentifier? textDocument,
@@ -32,16 +32,16 @@ public ClientCapabilities GetRequiredClientCapabilities ()
 
 	public T GetRequiredLspService<T>() where T : class, ILspService
     {
-        return services.GetRequiredService<T>();
+        return Services.GetRequiredService<T>();
     }
 
     public T GetRequiredService<T>() where T : class
     {
-        return services.GetRequiredService<T>();
+        return Services.GetRequiredService<T>();
     }
 
     public IEnumerable<T> GetRequiredServices<T>() where T : class
     {
-        return services.GetRequiredServices<T>();
+        return Services.GetRequiredServices<T>();
     }
 }