Add VS Code extension #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhutch
force-pushed
the
vscode-extension
branch
from
0997556
to
4f8ceab
Compare
mhutch
force-pushed
the
vscode-extension
branch
3 times, most recently
from
1eed0d3
to
4288ce4
Compare
Need to add dotnet-libraries to NuGet.config to get a new enough System.CommandLine version
The VS extension project has targets that call several tools that only work on Windows. Disable those targets specifically so that the full solution build works on non-Windows platforms. It will not produce the VSIX but we can at least verify that the VS extension project compiles after making changes in shared projects it depends on.
Some of the LSP code depends on Roslyn workspaces etc. but importing these as source got messy fast due to the web of dependencies. Instead, import them as package references and hope we don't run into any issues with lack of internals visibility.
Diagnostic titles do not have substituted values, only messages do
The parser service only handles parsing open files. When parsing other files, we should use the same state machine instance.
Thsi provides a hint that package search is available
* Unified CodeFixes and Refactorings into CodeActions layer, with a simple Kinds model that maps to VS and LSP * Added LSP-like model for edits returned by code actions * Add basic Roslyn-like options model * Replace per-buffer Roslyn SpellChecker with direct use of WordSimilarityChecker, like Roslyn's own spelling fix action * MSBuildRootDocument.Diagnostics is now expected to contain analyzer diagnostics as well as core diagnostics
mhutch
force-pushed
the
vscode-extension
branch
from
b06337e
to
c012eee
Compare
Fixes #246 - TaskMetadataBuilder causing infinite loop by overlapping reads/writes to a dictionary
Fixes #248 - Infinite CPU due to unprotected write to a HashSet<T>
At least partially addresses #236 - Performance made me disable the extension
Fixes #242 Package Reference TreatAsUsed is not recognized
Fixes #243 Item types defined via OutputItemType on ProjectReference are reported as not having a value assigned
Fixes #246 Assertion Failed when typing an & in (some) attributes
The way TaskMetadataBuilder loads info from assemblies is super hacky but it'll do for now. The original intent of using Roslyn was that it could load live metadata for tasks that were open as source code in the host. That worked in VSMac but has never worked in VSWin. For the cases where we're loading tasks from assemblies we'd probably be better off using System.Reflection.Metadata or something. We also need to load the reference assemblies for the BCL in order to find the docs XML, and bundle the Microsoft.Build.dll xml docs files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.