Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey There -
I saw this library and wanted to help you expand on the foundation here. I've always wanted a faker scala library that was built on top of scalacheck
Arbitrary
instances. 😄 I hope you'll accept some contributions here.I noticed that it was a bit hard to understand how to use the domains in the scalacheck area, as they were based off of the underlying dataset rather than the data's domain. This refactor is intended to organize the existing instances by the data's domain.
In this case, 2 domains were created:
name
andcompany
. I used package-objects to replicate yourall
instance setup. The end imports look like:import ahlers.faker.scalacheck.company.implicits._
Or, for the kitchen-sink:
import ahlers.faker.scalacheck.implicits._
Once this is in, I'd like to expand on this and add more domains, like
time
,lorem
, etc.Let me know what you think.