Skip to content

Commit

Permalink
Update release_docker_container.yaml (#442)
Browse files Browse the repository at this point in the history
* Update release_docker_container.yaml

 Add Conditional Build and Push: Enable optional image testing before pushing. This would help verify that images build correctly before being pushed to Docker Hub.

Enhanced Error Handling: Add fail-safe mechanisms, such as notifications or continue-on-error, for non-critical steps like cleanup. Also, explicitly handle errors in steps where failures should be alerted.

Caching for Faster Builds: Use a cache from Docker Hub to speed up builds, particularly useful when dependencies or base images remain the same across builds.

* Update release_docker_container.yaml

* Update release_docker_container.yaml

* Update release_docker_container.yaml

* Update release_docker_container.yaml

---------

Co-authored-by: Michael Feil <[email protected]>
  • Loading branch information
AranavMahalpure and michaelfeil authored Nov 11, 2024
1 parent 0784cf5 commit 6f239b4
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion .github/workflows/release_docker_container.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Free Disk Space
uses: "./.github/actions/disk_cleanup"
if: runner.os == 'Linux'
Expand All @@ -50,9 +51,11 @@ jobs:
large-packages: false
docker-images: false
swap-storage: false

- name: Get git tag
uses: actions-ecosystem/action-get-latest-tag@v1
id: get-latest-tag

- name: Set docker tag
env:
VERSION: ${{ steps.get-latest-tag.outputs.tag }}
Expand All @@ -61,8 +64,10 @@ jobs:
- name: Set up QEMU
uses: docker/setup-qemu-action@v3

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Login to Docker Hub
uses: docker/login-action@v3
with:
Expand Down Expand Up @@ -93,4 +98,4 @@ jobs:
# cache-from: type=registry,ref=${{ env.LATEST_TAG }}
platforms: ${{ inputs.platforms }}
tags: ${{ env.LATEST_TAG }}${{ env.APPENDIX_TAG }},${{ env.VERSION_TAG }}${{ env.APPENDIX_TAG }}
push: true
push: true

0 comments on commit 6f239b4

Please sign in to comment.