Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add base64 test for audio endpoint #414

Merged
merged 6 commits into from
Oct 11, 2024

Conversation

wirthual
Copy link
Collaborator

@wirthual wirthual commented Oct 11, 2024

This pull request updates the end-to-end tests for the torch_audio module in libs/infinity_emb. The main changes include refactoring the audio URL usage and adding new tests for base64-encoded audio.

Refactoring:

New Tests:

Dependency Updates:

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request adds tests for base64-encoded audio input in the audio embedding endpoint, enhancing the test coverage for audio embeddings as requested in issue #378.

  • Added test_audio_base64() to verify successful processing of base64-encoded audio input
  • Implemented test_audio_base64_fail() to handle invalid base64 input scenarios
  • Refactored audio URL to use pytest.AUDIO_SAMPLE_URL fixture for consistency
  • Improved test coverage for audio embedding functionality, addressing the need for more robust testing of audio inputs

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

libs/infinity_emb/tests/end_to_end/test_torch_audio.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.22%. Comparing base (6716258) to head (f403324).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #414   +/-   ##
=======================================
  Coverage   79.22%   79.22%           
=======================================
  Files          40       40           
  Lines        3167     3167           
=======================================
  Hits         2509     2509           
  Misses        658      658           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelfeil michaelfeil merged commit 61432aa into michaelfeil:main Oct 11, 2024
36 checks passed
@michaelfeil
Copy link
Owner

nice test, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants