Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aliases to dutch locale #370

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

rubenb994
Copy link
Contributor

@rubenb994 rubenb994 commented Feb 16, 2025

Hey @michaelwittig,

First of thanks for creating this repo! I've been building a world map game and this library has been a life saver. I just started using the Dutch locale and noticed some inconsistencies I've fixed in this PR.

This PR adds all the official names in Dutch and their commonly used names as the alias. It also fixes a very literal translation I found: Holy See was translated to Heilige Stoel while it should be Vaticaanstad.

  • I've run the linter and tests and all pass.

@michaelwittig michaelwittig merged commit fad3b24 into michaelwittig:master Feb 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants