Split camera device base class into Base and LegacyBase

[henrypinkard]

As discussed in: #243 (comment)

This splits the camera base class that all camera adapters derive from into a legacy class (CLegacyCameraBase) which derives from a new, preferred CCameraBase class. The primary difference between theses is that the Legacy class contains a bunch of code for implementing sequence acquisitions as a series of snaps, which was originally for debugging, but ends up being inherited by all camera devices adapters.

I changed the name to LegacyBase now, rather than in the future as described in (#243 (comment)), because it seems like we would already like device adapter writers to inherit from the new base class.

See below for a few questions.

[marktsuchida]

Thanks for doing this as a separate PR. I'm okay with immediately renaming to "legacy" -- makes sense if going ahead with modifying the camera adapters.

[henrypinkard]

It says you requested a change, but for some reason I don's see what that is. Is there anything else needed before merging this?

[marktsuchida]

It says you requested a change, but for some reason I don's see what that is.

I think you made the 'small fixes' commit at the same time I was reviewing. In it, you fixed PrepareSequenceAcqusition the way I requested.

But now that PrepareSequenceAcqusition is implemented in CCameraBase, presumably a bunch of cameras can have their change to CLegacyCameraBase undone?

Also, I commented that the Transpose_* properties should be kept in the base class because they are an entirely separate issue that needs analysis and cleanup.

(See my comments above that are marked resolved.)

[henrypinkard]

But now that PrepareSequenceAcqusition is implemented in CCameraBase, presumably a bunch of cameras can have their change to CLegacyCameraBase undone?

Probably. This was a simple refactor-rename, so I think that can be done in a separate step (#598)

Also, I commented that the Transpose_* properties should be kept in the base class because they are an entirely separate issue that needs analysis and cleanup.

Fixed in previous commit

[henrypinkard]

(See my comments above that are marked resolved.)

Should be all addressed now