Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password: switch the webview to the browser #2652

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

DaVinci9196
Copy link
Contributor

Fixed the issue on the account and password management settings page where clicking Import Password did not work.
Path: Password management page -> Enter the settings page in the upper right corner -> Click Import password

@mar-v-in
Copy link
Member

Do not open weblogin URLs in the browser directly. This will set cookies to sign in the user in the browser that the user might not want or expect. Best would be if you can figure out why the WebView does not work (you can try to connect a remote chrome debugger to the webview and then see if there are any issues logged), alternatively you need to at least ask the user to confirm they are going to be logged in before redirecting them into the signed in browser.

@DaVinci9196
Copy link
Contributor Author

Do not open weblogin URLs in the browser directly. This will set cookies to sign in the user in the browser that the user might not want or expect. Best would be if you can figure out why the WebView does not work (you can try to connect a remote chrome debugger to the webview and then see if there are any issues logged), alternatively you need to at least ask the user to confirm they are going to be logged in before redirecting them into the signed in browser.

Optimized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants