Location: moving WiFi location needs INTERNET permission

[TimoWilken]

Hopefully, this will fix #2704.

[ale5000-git]

@TimoWilken

Isn't it already fixed by this? fbd84a1

[TimoWilken]

Thanks @ale5000-git! I can try to test that the next time I'm on a German train, in a couple weeks' time.

Though I don't have a proxy configured on my phone (only a WireGuard VPN, but that only applies to 10.0.0.* IPs), and I did have network access through the in-train WiFi. The error in #2704 looks to me like it comes from a lower level than TLS/connection errors, but I'm not an Android developer.

[ale5000-git]

In the commit description:

Bypass ... and disable OCSP/CRL checks
...
OCSP/CRL might be impossible to resolve if in the hotspot no internet is available (e.g. in planes that have IFE without internet).

This is related to the https connection, maybe this was the problem.

[TimoWilken]

I'm not sure, because in my case, the hotspot did have internet available, so GmsCore should've been able to query OCSP and/or fetch CRLs.

To my untrained eye, it doesn't get as far as trying to set up an HTTPS connection, because the EPERM happens when setting up the socket.

But anyway, I'll try to test the latest version in two weeks' time.

[ale5000-git]

@mar-v-in
I'm not sure about this but maybe we still need the internet permission.

Info: https://developer.android.com/privacy-and-security/local-network-permission?hl=en
Quote:

Devices on a LAN can be accessed by any app that has the INTERNET permission

Quote:

If a device's DNS server is on a local network, traffic to / from it (at port 53) doesn't require local network access permission.

So if DNS isn't local we can't access it.

In Android 16+ we probably also need "local network access permission".

Quote:

Traffic originating from Android Webviews that require local network access will inherit permission state from the host app

[mar-v-in]

The INTERNET permission is already granted to microG from other manifests, so this PR does not actually change the resulting .apk and will not solve the issue. Regarding the underlying issue, see #2704 (comment)