-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to micropython 1.24.1 #4
base: main
Are you sure you want to change the base?
Conversation
This requires handling the following upstream commits: decf8e6a8b all: Remove the "STATIC" macro and just use "static" instead. 27279e69b4 esp32: Add IDF-version-specific sdkconfig. and, importantly acbdbcd95e esp32: Workaround IDF issue placing ISR ringbuf functions in IRAM Replacing STATIC was easy. Adding the IDF version specific was just implemented as upstream. However, the new linker.lf files are not in a path that is being searched properly. I believe this can only be fixed in micropython itself by providing a better file reference. The suggested upstream fix is available here: micropython/micropython#16658 and is _required_ for this patch. Signed-off-by: Karl Palsson <[email protected]>
(Obviously, because this relies on a patched upstream, this patch can't be merged as is, the submodule SHA would be wrong, but I need to show this for reference) |
Hi. Just one question: is this now the actual solution for 1.24.1 and ahead? |
Well, upstream has been merged now, so this just needs the same patch, with an updated submodule SHA, but otherwise, yes. Of course, upstream hasn't done a release yet, so perhaps this just waits to 1.25? You can see here what to do if you need it before hand, but I don't think pointing the micropython-example-boards repo to an intermediate micropython "just some point on main" is really a great idea. |
I followed the structure of the file while copying the linker into my main directory ans it start building my custom board with user module, but at about 75% of the build it throws an error:
Building the whole thing with the board definition in the micropython tree works, but outside is not working. I am using IDF 5.4 and probably is a bug in the have you tested this with IDF 5.3 or 5.4? |
I use 5.3.2 here. Note, the whole point of that upstream patch is so that you don't need to copy the linker fragment around, unless you're really needing special custom linker fragments. But, yes, clearly "unkonwn touch" is kinda out of scope of what I was doing here. |
Thanks for the info. Actually the touch driver is standard in the build. Anyway, I will try to do the whole thing the other way around and start by this PR and then incorporate my custom definitions and module in here step by step. |
This requires handling the following upstream commits: decf8e6a8b all: Remove the "STATIC" macro and just use "static" instead. 27279e69b4 esp32: Add IDF-version-specific sdkconfig. and, importantly
acbdbcd95e esp32: Workaround IDF issue placing ISR ringbuf functions in IRAM
Replacing STATIC was easy. Adding the IDF version specific was just implemented as upstream.
However, the new linker.lf files are not in a path that is being searched properly. I believe this can only be fixed in micropython itself by providing a better file reference.
The suggested upstream fix is available here: micropython/micropython#16658 and is required for this patch.
This supersedes: #3 (it uses/relies on a different solution with upstream)