Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNP derived key #6791

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

SNP derived key #6791

wants to merge 14 commits into from
+235 −36

Conversation

cjen1-msft
Copy link
Contributor

@cjen1-msft cjen1-msft commented Jan 31, 2025 •
edited
Loading

Add calls into /dev/guest-sev to generate a derived key.

TODO

  • Finish calls into testing
  • Document call better
  • Add wrapper in include/ccf/pal/snp_ioctl.h
  • Span

@cjen1-msft cjen1-msft force-pushed the derived_key branch 2 times, most recently from 48168fd to 5c58e7b Compare February 3, 2025 13:18
@cjen1-msft
Copy link
Contributor Author

The ioctl primitive is complete. However there is no way to mix the HostData into the derived key, so tying the key to a specific C-ACI policy is difficult.

@cjen1-msft
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cjen1-msft cjen1-msft marked this pull request as ready for review February 4, 2025 14:24
@cjen1-msft cjen1-msft requested a review from a team as a code owner February 4, 2025 14:24
@cjen1-msft
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

eddyashton
eddyashton reviewed Feb 4, 2025
View reviewed changes
src/pal/test/snp_ioctl_test.cpp Show resolved Hide resolved
include/ccf/pal/snp_ioctl6.h Show resolved Hide resolved
include/ccf/pal/snp_ioctl6.h Show resolved Hide resolved
@cjen1-msft cjen1-msft mentioned this pull request Feb 6, 2025
Open
@cjen1-msft
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cjen1-msft
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyashton eddyashton eddyashton left review comments

@maxtropets maxtropets maxtropets left review comments

@achamayou achamayou achamayou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjen1-msft @achamayou @eddyashton @maxtropets