Remove aad_len check on NULL out buffer #6820
Merged
+0
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not required to be set to something, but was check to freeze the existing implementation in microsoft#6610 when first migrating to AL3.0 and symcrypt. Now with the internal implementation changes this assertion is no longer true, therefore removed.
achamayou
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not required to be set to something, but was check to freeze the existing implementation in #6610 when first migrating to AL3.0 and symcrypt. Now with the internal implementation changes this assertion is no longer true, therefore removed.
UPD. 99% sure this's the cause: openssl/openssl#26658. Seems like error path fix, which also took away zeroing the data-written count.