Use ESNext modules in test-end-to-end-tests #15976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: tests
⯅ @fluid-example/bundle-size-tests: +30 Bytes
Baseline commit: d4265d9 |
|
I wasn't familiar with why we needed to specify the file extension now, but that's covered here if anyone is interested in the change in module resolution for ESNext modules in NodeJS: https://nodejs.org/docs/latest-v16.x/api/esm.html#import-specifiers. |
justus-camp
approved these changes
Jun 15, 2023
yup, good reference. Also see microsoft/TypeScript#33588 for some comments from the typescript team on why it's a |
DLehenbauer
pushed a commit
that referenced
this pull request
Feb 21, 2024
build(client): use fluid-tsc for Node16 test builds - remove now stale tsc-multi configurations and replace all use with fluid-tsc. - enable ESM build for tree test - Make ajvValidator CommonJS to accommodate typescript's rejection of Ajv's handcrafted ES Module support. - *However*, ESM test build is not runnable per internal module import of id-compressor CommonJS output (`@fluidframework/id-compressor/dist/test`). - correct @fluid-private/test-end-to-end-tests build dependencies (was changed to ESNext in #15976) and @fluidframework/container-runtime test support was previously moved to production (in #18826). - update build-tools Updated the following: client (release group) client-release-group-root Dependencies on build-tools updated: @fluid-tools/build-cli: 0.34.0 @fluidframework/build-tools: 0.34.0 @fluidframework/bundle-size-tools: 0.34.0 @fluid-tools/version-tools: 0.34.0 Command used: ```shell pnpm flub bump deps build-tools -g client -t latest --updateChecker homegrown -x ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Transitions
@fluid-internal/test-end-to-end-teststo ESNext modules.This makes progress toward #15917, a planned improvement for
describeCompat.