Use kernel for internal access in tree, split out ChannelView #23888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
There was a problem hiding this comment.
Copilot reviewed 6 out of 21 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- packages/dds/tree/src/test/shared-tree/sharedTree.spec.ts: Evaluated as low risk
- packages/dds/shared-object-base/src/sharedObject.ts: Evaluated as low risk
- packages/dds/tree/src/test/shared-tree/schematizingTreeView.spec.ts: Evaluated as low risk
- packages/dds/tree/src/test/shared-tree/summary.bench.ts: Evaluated as low risk
- packages/dds/tree/src/test/feature-libraries/indexing/treeIndex.spec.ts: Evaluated as low risk
- packages/dds/tree/src/test/shared-tree-core/utils.ts: Evaluated as low risk
- packages/dds/tree/src/test/snapshots/snapshotTestScenarios.ts: Evaluated as low risk
- packages/dds/tree/src/shared-tree-core/sharedTreeCore.ts: Evaluated as low risk
- packages/dds/tree/src/test/feature-libraries/chunked-forest/chunkEncodingEndToEnd.spec.ts: Evaluated as low risk
- packages/dds/tree/src/test/shared-tree/fuzz/fuzzEditGenerators.ts: Evaluated as low risk
- packages/dds/tree/src/test/shared-tree/sharedTree.bench.ts: Evaluated as low risk
- packages/dds/tree/src/test/shared-tree/treeCheckout.spec.ts: Evaluated as low risk
- packages/dds/shared-object-base/src/index.ts: Evaluated as low risk
- packages/dds/tree/src/test/shared-tree/repairData.spec.ts: Evaluated as low risk
- packages/dds/tree/src/index.ts: Evaluated as low risk
alex-pardes
approved these changes
Feb 25, 2025
Josmithr
approved these changes
Feb 25, 2025
Josmithr
approved these changes
Feb 25, 2025
chentong7
pushed a commit
to chentong7/FluidFramework
that referenced
this pull request
Mar 11, 2025
…oft#23888) ## Description Cleanup split out from microsoft#23885, This works toward a pattern where we have a common kernel interface (which will take in ChannelView), which has the internals of the DDS. This introduces channel view at the shared object layer, and makes more access to internals in tree for testing go through kernel. This makes it easier to split up the API from the implementation of SharedTree, as well as easier to port these tests to target kernel directly in the future, and not depend on SharedObject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanup split out from #23885,
This works toward a pattern where we have a common kernel interface (which will take in ChannelView), which has the internals of the DDS.
This introduces channel view at the shared object layer, and makes more access to internals in tree for testing go through kernel.
This makes it easier to split up the API from the implementation of SharedTree, as well as easier to port these tests to target kernel directly in the future, and not depend on SharedObject
Reviewer Guidance
The review process is outlined on this wiki page.