Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools(client): refresh eslint related dependency resolutions #23915

Merged
merged 1 commit into from
Feb 24, 2025
Merged

tools(client): refresh eslint related dependency resolutions #23915

merged 1 commit into from
Feb 24, 2025

Conversation

jason-ha
Copy link
Contributor

Process:

  1. inject a new internal package interdependency
  2. pnpm i --no-frozen-lockfile
  3. revert internal package dep (keep misc resolution updates)

@jason-ha
tools(client): refresh eslint related dependency resolutions
3716918 
Process:
1. inject a new internal package interdependency
2. pnpm i --no-frozen-lockfile
3. revert internal package dep (keep misc resolution updates)
@jason-ha jason-ha requested review from Copilot, CraigMacomber and markfields and removed request for Copilot February 24, 2025 19:03
@github-actions github-actions bot added dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Feb 24, 2025
markfields
markfields approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@markfields markfields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

@jason-ha jason-ha merged commit e088330 into microsoft:main Feb 24, 2025
33 checks passed
@jason-ha jason-ha deleted the build-force-eslint-resolution-update branch February 24, 2025 22:47
@jason-ha
Copy link
Contributor Author

Hmm. Looks like this merged with no changes. Same changes were committed as part of 50ac778 (#23565).

chentong7 pushed a commit to chentong7/FluidFramework that referenced this pull request Mar 11, 2025
@jason-ha @chentong7
tools(client): refresh eslint related dependency resolutions (microso…
d51e1d2 
…ft#23915)

Process:
1. inject a new internal package interdependency
2. pnpm i --no-frozen-lockfile
3. revert internal package dep (keep misc resolution updates)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markfields markfields markfields approved these changes

@CraigMacomber CraigMacomber Awaiting requested review from CraigMacomber

Assignees
No one assigned
Labels
base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jason-ha @markfields