test: added payload too large test #24021
Draft
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: runtime
markfields
reviewed
Mar 11, 2025
| @@ -82,7 +82,7 @@ export class OpCompressor { | |||
| /** | |||
| * Combine the batch's content strings into a single JSON string (a serialized array) | |||
| */ | |||
| private serializeBatchContents(batch: IBatch): string { | |||
| public serializeBatchContents(batch: IBatch): string { | |||
There was a problem hiding this comment.
I think it's worth adding a comment (and updating the type) that this will just have one element. So this will only add the two square bracket characters.
It's a tiny window where this step could be the one that yields a string that's too long.
There was a problem hiding this comment.
So the test case you're adding isn't possible in reality because the compressor would bail if there's more than one message.
| assert.throws( | ||
| () => { | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-call | ||
| compressor.serializeBatchContents(batch); |
There was a problem hiding this comment.
You can call this even if it's private, you just have to work around the regular type. I can show you another example of this on the phone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In OpCompressor.ts there is a serializeBatchContents function that returns an error message if the code being sent is too large, that is no longer reachable with existing tests and we need to create new ones so that we can be prepared for this event if it were to happen in production code.
Acceptance Criteria
There is a test that covers the code in opCompressor.ts
Execution Plan
Create a new test inside opCompressor.ts that has the ability to reach said code.
Reviewer Guidance
Let me know if there's a better way to go about doing this.